Skip to content

Update review cancellation instructions and screenshot - #45812

Merged
subatoi merged 2 commits into
github:mainfrom
ashis-baral:review-pull-requests
Sep 9, 2026
Merged

Update review cancellation instructions and screenshot#45812
subatoi merged 2 commits into
github:mainfrom
ashis-baral:review-pull-requests

Conversation

@ashis-baral

@ashis-baral ashis-baral commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Why:

fix: #45811

What's being changed (if available, include any code snippets, screenshots, or gifs):

Updated the instructions in the "Starting a review" section of the pull request review documentation to reflect the current GitHub UI.

The previous instructions directed users to click Review changes, then Abandon review. In the current UI, users need to click Submit review, then click Discard review to cancel a pending review.

Also replaced the outdated screenshot with an updated screenshot showing the current Submit review → Discard review workflow.

abandon-review-button

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@ashis-baral
Fix instructions for abandoning a review
be1c61f 
Updated the instructions for canceling a pending review to reflect the correct button actions.
@ashis-baral
Add files via upload
5328582
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Sep 9, 2026
@docs-bot docs-bot added the invalid This issue/PR is invalid label Sep 9, 2026
@docs-bot

docs-bot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

👋 Hi there! It looks like you've modified some files that we can't accept as contributions:

  • assets/images/help/pull_requests/abandon-review-button.png

You'll need to raise a new PR that doesn't include those files, before we can review.

The complete list of files we can't accept are:

  • Anything in the root directory
  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • .vscode/**
  • assets/**
  • config/**
  • contributing/**
  • src/**
  • patches/**
  • content/actions/how-tos/secure-your-work/security-harden-deployments/**

We also can't accept contributions to files in the content directory with frontmatter contentType: rai. You can always check out our full contribution guidelines.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
pull-requests/how-tos/review-pull-requests/reviewing-proposed-changes-in-a-pull-request.md fpt
ghec
ghes@ 3.22 3.21 3.20 3.19 3.18 3.17
fpt
ghec
ghes@ 3.22 3.21 3.20 3.19 3.18 3.17

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@github-actions github-actions Bot closed this Sep 9, 2026
@subatoi subatoi reopened this Sep 9, 2026
@docs-bot

docs-bot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

👋 Hi there! It looks like you've modified some files that we can't accept as contributions:

  • assets/images/help/pull_requests/abandon-review-button.png

You'll need to raise a new PR that doesn't include those files, before we can review.

The complete list of files we can't accept are:

  • Anything in the root directory
  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • .vscode/**
  • assets/**
  • config/**
  • contributing/**
  • src/**
  • patches/**
  • content/actions/how-tos/secure-your-work/security-harden-deployments/**

We also can't accept contributions to files in the content directory with frontmatter contentType: rai. You can always check out our full contribution guidelines.

subatoi
subatoi requested changes Sep 9, 2026
View reviewed changes

@subatoi subatoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ashis-baral—I'm happy to accept this but we have stringent requirements on image quality. I think we can just delete this image, so if you'd like to go ahead and do that in your PR, I'll accept it and we can merge it. Thank you!

@ashis-baral

ashis-baral commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

HI @subatoi I just want to double check — I captured this screenshot specifically following the technical requirements in the Creating screenshots guide, and it checks out against all of them:

Format: PNG ✅
DPI: 144 dpi ✅
Width: 995px (within the 750–1000px range) ✅
File size: ~137 KB (under the 250 KB limit) ✅
Theme: Light theme, matches current UI ✅
Highlighting: Used the fg.severe dark orange stroke (
#BC4C00) around the "Discard review" button.
So on the documented technical spec, it looks compliant — happy to be corrected if there's a specific issue with it (compression artifacts, cropping, wrong element highlighted, etc.)

subatoi
subatoi approved these changes Sep 9, 2026
View reviewed changes

@subatoi subatoi left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashis-baral So you did — it's so rare that contributors actually follow those guidelines correctly that I have to admit I didn't check, so I do apologise about that. I'll go ahead and get this merged 🙇

@subatoi
subatoi added this pull request to the merge queue Sep 9, 2026
Merged via the queue into github:main with commit 0397eae Sep 9, 2026
105 of 109 checks passed
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@ashis-baral

ashis-baral commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

@subatoi Ha, no worries at all — glad it checked out! Thanks for taking another look and for merging it. I really appreciate it. 👍

@subatoi

subatoi commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

No problem—thank you for your help, again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@subatoi subatoi subatoi approved these changes

Assignees

No one assigned

Labels

invalid This issue/PR is invalid triage Do not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update outdated review cancellation instructions and screenshot

3 participants

@ashis-baral @docs-bot @subatoi